<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jul 7, 2009, at 11:52 PM, Enea Zaffanella wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Eli Friedman wrote:<br><blockquote type="cite">On Tue, Jul 7, 2009 at 3:46 AM, Enea Zaffanella<<a href="mailto:zaffanella@cs.unipr.it">zaffanella@cs.unipr.it</a>> wrote:<br></blockquote><blockquote type="cite"><blockquote type="cite">Index: include/clang/Basic/DiagnosticSemaKinds.td<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">===================================================================<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">--- include/clang/Basic/DiagnosticSemaKinds.td (revision 74831)<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">+++ include/clang/Basic/DiagnosticSemaKinds.td (working copy)<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">@@ -1191,6 +1191,8 @@<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> "arithmetic on pointer to void type">;<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> def err_typecheck_decl_incomplete_type : Error<<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"> "variable has incomplete type %0">;<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">+def warn_typecheck_decl_incomplete_type : Warning<<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">+ "variable has incomplete type %0">;<br></blockquote></blockquote><blockquote type="cite">This should be an ExtWarn; it's generally the preferred classification<br></blockquote><blockquote type="cite">for issues which make the translation unit undefined at compile-time.<br></blockquote><blockquote type="cite">Also, it would be nice to explicitly point out the issue, more like<br></blockquote><blockquote type="cite">"tentative definition of variable with internal linkage has incomplete<br></blockquote><blockquote type="cite">type %0" (I actually don't particularly like that wording, but the<br></blockquote><blockquote type="cite">issue is a bit technical, so I'm not sure how to rephrase it.)<br></blockquote><br>The message now reads:<br><br>"tentative definition of variable with internal linkage has incomplete non-array type %0"<br><br>This also tells that an array type would directly lead to an error (which is the behavior in gcc).</div></blockquote><div><br></div><div>[snip]</div><div><br></div><blockquote type="cite"><div>Please find attached the revised patch.<br></div></blockquote></div><div><br></div>Looks good, thanks! Committed here:<div><span class="Apple-tab-span" style="white-space:pre"> </span></div><div><span class="Apple-tab-span" style="white-space:pre"> <a href="http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20090720/019238.html">http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20090720/019238.html</a></span></div><div><span class="Apple-tab-span" style="white-space:pre"> </span><br><div> - Doug</div></div></body></html>