<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Apr 20, 2009, at 10:15 PM, Alexei Svitkine wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Here's an updated patch.</blockquote><div><br></div>Thanks Alexei, getting better. Minor nit picks:</div><div><br></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Monaco; ">+//===--- InitPreprocessor.h - InitializePreprocessor function. --*- C++ -*-===//</div><div><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;">..</span></font></div><div><font class="Apple-style-span" face="Monaco" size="2"><span class="Apple-style-span" style="font-size: 10px;"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Monaco; ">+</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Monaco; ">+#include "llvm/Support/CommandLine.h"</div><div><br></div><div>Please don't include this here, it should just be in clang-cc.</div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Monaco; ">+#include <algorithm></div><div><br></div><div>This shouldn't be needed by the header.</div><div><br></div></div><div><br></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Monaco; ">+++ lib/Frontend/InitPreprocessor.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>(revision 0)</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Monaco; ">@@ -0,0 +1,470 @@</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Monaco; ">+//===--- InitPreprocessor.h - InitializePreprocessor function. --*- C++ -*-===//</div><div><br></div><div>Please fix comment line.</div><div><br></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Monaco; ">+#include "llvm/Support/CommandLine.h"</div><div><br></div><div>Please remove this and any other dead #includes from the .cpp.</div><div><br></div><div><br></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 10px/normal Monaco; ">+// FIXME: -imacros</div><div><br></div><div>We support imacros now, this can be removed :)</div><div><br></div><div>Otherwise, looks great!</div><div><br></div><div>-Chris</div></div></div></div></span></font></div></div></body></html>