<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Apr 20, 2009, at 4:51 PM, Alexei Svitkine wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Hi,<div><br></div><div>This is a patch for <a href="http://llvm.org/bugs/attachment.cgi?bugid=3979">http://llvm.org/bugs/attachment.cgi?bugid=3979</a>.</div><div><br></div><div>It moves InitializePreprocessor() functionality to its own file under lib/Frontend from clang-cc.cpp.</div> <div><br></div><div>This allows users of the clang libraries to properly initialize all the expected macros without copying and pasting 500 lines of code from clang-cc.cpp.</div><div><br></div><div>Not included are changes to Makefiles and such to properly add the new InitializePreprocessor.cpp file to the build system, since I do not know what is needed there.</div> <div></div></blockquote></div><br><div>Hi Alexei,</div><div><br></div><div>This looks generally fine, except that we really prefer libfrontend to not use cl::opt at all. We want all the command line option processing stuff to be in clang-cc, not in any lib directories. Can you refactor the code to populate a class from the command line options and pass that in instead?</div><div><br></div><div>Thanks,</div><div><br></div><div>-Chris</div></body></html>