[cfe-dev] Match callback invocation order

Billy O'Mahony via cfe-dev cfe-dev at lists.llvm.org
Mon Jun 22 12:50:47 PDT 2020


Thanks to Stephen and David for your help. I've filed a bug report
https://bugs.llvm.org/show_bug.cgi?id=46423

On Sat, 20 Jun 2020 at 17:26, Stephen Kelly <steveire at gmail.com> wrote:

>
> On 19/06/2020 15:38, Billy O'Mahony wrote:
> > Hi Stephen,
> >
> > thanks for the input.
> >
> > Fortunately it's just C I'm interested in.
> >
> > It's not just the order of certain function calls that are relevant;
> > the ordering of some conditional expressions and return stmts are also
> > relevant. And some of them are done via macros in which case, if I
> > recall, I see the source location being the location of the macro
> > definition - not the location of the macro usage.
>
>
> Yes, macros add complexity.
>
>
> >
> > It still sounds to me like MatchFinder is not doing exactly what it
> > says on the tin "The order of matches is guaranteed to be equivalent
> > to doing a pre-order traversal on the AST, and applying the matchers
> > in the order in which they were added to the MatchFinder."
>
>
> Yes, this is at least a documentation bug, if the implementation isn't
> changed.
>
> Thanks,
>
> Stephen.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20200622/90c8debf/attachment.html>


More information about the cfe-dev mailing list