[cfe-dev] Turn off lint pre-merge checks for test/

Nathan James via cfe-dev cfe-dev at lists.llvm.org
Mon Jul 6 06:49:40 PDT 2020


In that specific example it looks like clang-format is actually being
helpful for the test file. If clang-format findings start to break test
cases thats when something should be done to silence them.

~Nathan
On Mon, 2020-07-06 at 14:31 +0100, Bruno Ricci via cfe-dev wrote:
> 
> On 06/07/2020 14:04, Nathan James via cfe-dev wrote:
> > Some of the test folders already have .clang-format files which
> > just
> > override the column limit
> > ----------------------------------------------------
> > BasedOnStyle: LLVM
> > ColumnLimit: 0
> > ----------------------------------------------------
> > If the issues with formatting are just FileCheck comments being too
> > long, this is a probably the way to go.
> > If the issue with formatting is say trying to extract some kind of
> > diagnostic it may be wise to just wrap the bad code in `clang-
> > format
> > on/off` comments.
> > Losing all formatting of test files would be a step backwards WDYT?
> > 
> > ~Nathan
> > 
> 
> Hum, so there is already test/.clang-format which does the above.
> 
> In the patch which motivated this email (
> https://reviews.llvm.org/D83183)
> most of the noise is caused by complaints about the indentation of
> CHECK lines.
> 
> Perhaps I just need to do a quick clang-format and forget about it.
> 
> Bruno
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev



More information about the cfe-dev mailing list