[cfe-dev] update_cc_test_checks.py and function declarations

[David Greene via cfe-dev]

Alexander Richardson via cfe-dev <cfe-dev at lists.llvm.org> writes:

> Hi David,
>
> This looks like a regression from when I added the JSON AST dump parsing
> code.
> I never tried using it on a file with both definition and declaration for
> the same function. I've posted https://reviews.llvm.org/D73708 which should
> fix this issue.

Looks great, thank you!

                 -David

> On Wed, 29 Jan 2020 at 17:56, David Greene <dag at cray.com> wrote:
>
>> David Greene <dag at cray.com> writes:
>>
>> > void foo();
>> >
>> > int main() {
>> >   foo();
>> >   return 0;
>> > }
>> >
>> > void foo() {
>> >   ...
>> > }
>> >
>> > The checks for foo were put in front of the definition of foo.  Now I am
>> > seeing the checks put in front of the declaration of foo, which messes
>> > up the CHECK-LABEL ordering.
>>
>> Actually, I see the checks place *both* before the declaration *and*
>> before the definition.
>>
>>                       -David
>>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev