[cfe-dev] [RFC] Use preferred alignment instead of ABI alignment for complete object when applicable

[Xiangling Liao via cfe-dev]

A patch related to our discussions are posted here:
https://reviews.llvm.org/D86790.


Thank you,
Xiangling

On Mon, Aug 24, 2020 at 3:39 PM Hubert Tong <
hubert.reinterpretcast at gmail.com> wrote:

> On Mon, Aug 24, 2020 at 12:29 PM James Y Knight <jyknight at google.com>
> wrote:
>
>> Making a change like that privately while you're working through the list
>> of callers could be a useful strategy to help keep track of which callers
>> you've checked for correctness already. It might even be useful to send in
>> a draft review, to ask for help in determining which of these callsites
>> should and should not be modified.
>>
>> But I don't think it'd be useful to actually check that change in.
>>
> Actually checking it in temporarily can locate additional calls in
> patches-in-flight. That is a possible advantage.
>
>
>>
>> I currently would expect that the vast majority of the time, the code
>> is correct to be using the guaranteed "ABI" alignment, and only a small
>> number of places need to be changed to use the preferred type alignment.
>>
> Are these places sufficiently rare that we are unconcerned with
> occurrences of these that may be exclusively downstream at this point in
> time?
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20200828/821523a2/attachment.html>