[cfe-dev] [llvm-dev] Splitting up Type.h: Good idea, bad idea?

Chris Lattner via cfe-dev cfe-dev at lists.llvm.org
Wed Apr 8 13:29:13 PDT 2020


Modules are great, but splitting up headers files is still a good idea for maintenance and readability of the codebase…

-Chris

> On Apr 8, 2020, at 12:05 PM, David Blaikie via cfe-dev <cfe-dev at lists.llvm.org> wrote:
> 
> Have you tried building with modules enabled? (as Lubos mentioned, it's already supported by the LLVM build). What kind of scaling factors do you expect to be problematic in LLVM's build?
> 
> On Wed, Apr 8, 2020 at 9:59 AM Reid Kleckner via cfe-dev <cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>> wrote:
> On Wed, Apr 8, 2020 at 5:15 AM Lubos Lunak <l.lunak at centrum.cz <mailto:l.lunak at centrum.cz>> wrote:
>  If you intend to improve compile time, wouldn't it be better to focus on 
> already existing ways to do that? Specifically with -DLLVM_ENABLE_MODULES=On 
> I'd expect Type.h to not matter for compile times at all.
> 
> It's true that modules are generally defined at a larger granularity, and pruning includes this way will not affect modular build time. However, I am generally skeptical that using modules is a scalable way to speed up local builds.
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev <https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20200408/4f25e2d3/attachment.html>


More information about the cfe-dev mailing list