[cfe-dev] [llvm-dev] Mailing list changes this week
Robinson, Paul via cfe-dev
cfe-dev at lists.llvm.org
Wed Oct 16 12:26:52 PDT 2019
> -----Original Message-----
> From: Tom Stellard <tstellar at redhat.com>
> Sent: Wednesday, October 16, 2019 3:14 PM
> To: Roman Lebedev <lebedev.ri at gmail.com>
> Cc: Robinson, Paul <paul.robinson at sony.com>; Shoaib Meenai
> <smeenai at fb.com>; Mehdi AMINI <joker.eph at gmail.com>; llvm-
> dev at lists.llvm.org; cfe-dev <cfe-dev at lists.llvm.org>; openmp-dev (openmp-
> dev at lists.llvm.org) <openmp-dev at lists.llvm.org>; LLDB Dev <lldb-
> dev at lists.llvm.org>
> Subject: Re: [llvm-dev] [cfe-dev] Mailing list changes this week
>
> On 10/16/2019 12:02 PM, Roman Lebedev wrote:
> > On Wed, Oct 16, 2019 at 9:55 PM Tom Stellard <tstellar at redhat.com>
> wrote:
> >>
> >> On 10/16/2019 07:31 AM, Roman Lebedev wrote:
> >>> +1, please.
> >>>
> >>> Also, putting a tag on the *first* commit in the repo,
> >>> and doing `git describe --match FIRST_COMMIT_TAG` will be *great*!
> >>>
> >>
> >> Do we need to add a tag or is `git rev-list --count HEAD`
> >> good enough?
> > Ah, interesting, that works too, better than nothing.
> > But to be noted that number is different from the `llvm-svn: <>` for
> > the current commit.
> >
>
> This is expected. There were a few commits that were filtered
> out in the SVN to git conversion:
>
> https://github.com/jyknight/llvm-git-migration/blob/master/llvm-svn2git-
> monorepo.rules
Does the same tactic work for the release branches? Or are we going to
see some duplicate count numbers on master and the branches? That might
be confusing. (FYI at Sony, for release we count revs since the branch,
so the monotonic numbers on branches are generally small.)
--paulr
>
> -Tom
>
> >> -Tom
> > Roman
> >
> >>> Roman.
> >>>
> >>> On Wed, Oct 16, 2019 at 5:23 PM Robinson, Paul via llvm-dev
> >>> <llvm-dev at lists.llvm.org> wrote:
> >>>>
> >>>> +1. And put it in the email (subject?). While it’s possible to
> derive a count from a hash manually, better to have it in the email in the
> first place. You can’t rely on order-of-email-delivery to reflect order-
> of-commit.
> >>>>
> >>>> --paulr
> >>>>
> >>>>
> >>>>
> >>>> From: llvm-dev <llvm-dev-bounces at lists.llvm.org> On Behalf Of Shoaib
> Meenai via llvm-dev
> >>>> Sent: Wednesday, October 16, 2019 1:42 AM
> >>>> To: tstellar at redhat.com; Mehdi AMINI <joker.eph at gmail.com>
> >>>> Cc: llvm-dev <llvm-dev at lists.llvm.org>; cfe-dev <cfe-
> dev at lists.llvm.org>; openmp-dev (openmp-dev at lists.llvm.org) <openmp-
> dev at lists.llvm.org>; LLDB Dev <lldb-dev at lists.llvm.org>
> >>>> Subject: Re: [llvm-dev] [cfe-dev] Mailing list changes this week
> >>>>
> >>>>
> >>>>
> >>>> I thought we were just going to count commits on a particular branch
> and use the (branch name, commit count) tuple as our monotonic
> incrementing identifier?
> https://llvm.org/docs/Proposals/GitHubMove.html#on-managing-revision-
> numbers-with-git
> >>>>
> >>>>
> >>>>
> >>>>
> >>>>
> >>>> From: cfe-dev <cfe-dev-bounces at lists.llvm.org> on behalf of cfe-dev
> <cfe-dev at lists.llvm.org>
> >>>> Organization: Red Hat
> >>>> Reply-To: "tstellar at redhat.com" <tstellar at redhat.com>
> >>>> Date: Tuesday, October 15, 2019 at 10:13 PM
> >>>> To: Mehdi AMINI <joker.eph at gmail.com>
> >>>> Cc: llvm-dev <llvm-dev at lists.llvm.org>, cfe-dev <cfe-
> dev at lists.llvm.org>, "openmp-dev (openmp-dev at lists.llvm.org)" <openmp-
> dev at lists.llvm.org>, LLDB Dev <lldb-dev at lists.llvm.org>
> >>>> Subject: Re: [cfe-dev] Mailing list changes this week
> >>>>
> >>>>
> >>>>
> >>>> On 10/15/2019 09:44 PM, Mehdi AMINI wrote:
> >>>>
> >>>> On Tue, Oct 15, 2019 at 9:33 PM Tom Stellard <tstellar at redhat.com
> <mailto:tstellar at redhat.com>> wrote:
> >>>>
> >>>> On 10/15/2019 09:24 PM, Mehdi AMINI wrote:
> >>>>
> >>>> > Hi Tom.
> >>>>
> >>>> >
> >>>>
> >>>> > One issue with this is that we don't have a clear "ordering"
> from linear revision numbers from these emails. Have we looked into
> continuing to generate our own emails per commits instead so that we
> control the format?
> >>>>
> >>>> >
> >>>>
> >>>> This actually what we are doing, we are listening for github
> commit events and
> >>>>
> >>>> then generating our own emails based on the data in the event.
> We can format
> >>>>
> >>>> the emails how ever we want, and we tried to match the current
> SVN format exactly.
> >>>>
> >>>> Ah great!
> >>>>
> >>>>
> >>>>
> >>>> Is the some other information you would like to have in the
> emails to show the
> >>>>
> >>>> ordering?
> >>>>
> >>>> The only thing I was looking to get was to continue to have a
> monotonic incrementing integer for the revision instead of the git hash
> alone: I don't know if `git llvm` has this feature yet but this was
> discussed a while ago (I don't remember if we just mentioned counting the
> commits in the repo from the beginning or using an invocation of `git
> describe` or something derived).
> >>>>
> >>>>
> >>>>
> >>>> We talked about using `git describe` for this, but this would require
> that we
> >>>>
> >>>> add tags to the master branch each time the version number was
> bumped. We
> >>>>
> >>>> discussed this[1] last year, but deferred the decision, since we
> couldn't get
> >>>>
> >>>> consensus on the tag name.
> >>>>
> >>>>
> >>>>
> >>>> -Tom
> >>>>
> >>>>
> >>>>
> >>>> [1] https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__lists.llvm.org_pipermail_llvm-2Ddev_2018-
> 2DDecember_128484.html&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQX
> KeTWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=p_75z-
> WV3dFcBRoqs2YeTexKxeCf8oyS-atIo6wG6Fg&e=
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>>
> >>>> Mehdi
> >>>>
> >>>>
> >>>>
> >>>> -Tom
> >>>>
> >>>> > Thanks,
> >>>>
> >>>> >
> >>>>
> >>>> > --
> >>>>
> >>>> > Mehdi
> >>>>
> >>>> >
> >>>>
> >>>> >
> >>>>
> >>>> >
> >>>>
> >>>> > On Tue, Oct 15, 2019 at 9:07 PM Tom Stellard via cfe-dev <cfe-
> dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org> <mailto:cfe-
> dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>>> wrote:
> >>>>
> >>>> >
> >>>>
> >>>> > Hi,
> >>>>
> >>>> >
> >>>>
> >>>> > We are going to start to switching from SVN commit emails
> to GitHub commit
> >>>>
> >>>> > emails this week. The only real change you should notice
> is that
> >>>>
> >>>> > the revision number in the subject will be replaced with a
> git hash and
> >>>>
> >>>> > the diff links in the email will point to GitHub.
> Otherwise the
> >>>>
> >>>> > content and format of the email should be the same.
> >>>>
> >>>> >
> >>>>
> >>>> > We are going to start by rolling this out for the openmp-
> commits list
> >>>>
> >>>> > and then once that's working begin migrating the rest of
> the lists. If you
> >>>>
> >>>> > notice any issues with the new emails, please file a bug
> and mark it
> >>>>
> >>>> > as a blocker of the github meta-bug (llvm.org/PR39393
> <https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__llvm.org_PR39393&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKe
> TWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=eX8PTSE7QycIi5KeESJj
> 4VzteOcs9k7RANSWPgiiQ2Q&e= >
> <https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__llvm.org_PR39393&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKe
> TWOMw&m=_SmpuqSzuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=eX8PTSE7QycIi5KeESJj
> 4VzteOcs9k7RANSWPgiiQ2Q&e= >).
> >>>>
> >>>> >
> >>>>
> >>>> > Thanks,
> >>>>
> >>>> > Tom
> >>>>
> >>>> > _______________________________________________
> >>>>
> >>>> > cfe-dev mailing list
> >>>>
> >>>> > cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>
> <mailto:cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>>
> >>>>
> >>>> > https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-
> 2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqS
> zuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=xRFk9gEi6pLejTNAvlPR6gtikLoWNgyvL7b
> -TAvUcnc&e=
> >>>>
> >>>> >
> >>>>
> >>>>
> >>>>
> >>>> _______________________________________________
> >>>>
> >>>> cfe-dev mailing list
> >>>>
> >>>> cfe-dev at lists.llvm.org
> >>>>
> >>>> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-
> 2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=_SmpuqS
> zuAhMoF3exJmWRp6KnerIOE6WdU4kcv3tjhQ&s=xRFk9gEi6pLejTNAvlPR6gtikLoWNgyvL7b
> -TAvUcnc&e=
> >>>>
> >>>>
> >>>>
> >>>> _______________________________________________
> >>>> LLVM Developers mailing list
> >>>> llvm-dev at lists.llvm.org
> >>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> >>
More information about the cfe-dev
mailing list