[cfe-dev] [RFC] Clang SourceLocation overflow

Mikhail Maltsev via cfe-dev cfe-dev at lists.llvm.org
Tue Nov 5 03:28:10 PST 2019


On 11/2/19 5:00 PM, Matt Asplund wrote:
> I have attached a patch for the changes to update SourceLocation to internally
> use an unsigned long long (I tried to put it on phabricator, but it was not
> having my changes). The change is as isolated as I could make it to allow a
> majority of clang to continue to use the old 32 bit ids whenever possible and
> only convert locations that I was personally hitting overflows (when trying to
> convert down) during large pcm lazy loading. Note: There may be a few random
> C++20 Modules fixes and/or hacks sprinkled in, this was entirely to unblock my
> own investigations into a C++ Modules build system.
> 
> -Matt

Thanks for sharing. We will look into your patch.


-- 
Regards,
  Mikhail Maltsev


More information about the cfe-dev mailing list