[cfe-dev] [llvm-dev] FYI: LLVM Phabricactor notifications.
David Jones via cfe-dev
cfe-dev at lists.llvm.org
Fri May 31 17:28:43 PDT 2019
I tweaked the notifications yesterday, hopefully we don't see more spam
storms.
For filtering git refs: this is something that has changed substantially in
Phabricator over the past couple of months, but I think I've managed to
restrict notifications to only "master." (Although, again, this has changed
a lot... getting this right depends on my own archaeological skills for
digging through old revisions of the Phab documentation.)
There are some complicating factors in deciding what the notifications
should actually be doing... one major source of complexity stems from the
fact that we re-import most commits multiple times. This makes it hard to
reason about how different notifications will fire, and which source will
actually autoclose differential revisions.
The current state is that most commits should notify the committer twice:
once for the Subversion repo (repo callign rL), and once for git master
(rG). I think this may actually be the best state while we're living in
both worlds: the SVN commit is the source of truth, but a lot of folks care
about re-syncing from Git, so that also seems like something folks will
want. Of course, this is a transitional pain point, and there's not going
to be a single configuration that can satisfy every possible thing folks
would want.
One particular change: I've disabled notifications for the duplicate
Subversion meta-repos... so, for example, a commit to Clang will still get
2 notifications (rL and rG). Before yesterday, this should have sent 3: one
each for rL, rG, and rC. Projects not in the monorepo will get
notifications for rL only.
On Fri, May 31, 2019 at 2:15 AM Manuel Klimek via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> On Fri, May 31, 2019 at 10:53 AM MyDeveloper Day <mydeveloperday at gmail.com>
> wrote:
>
>> I actually run a in-house Phabricator instance with 400+ users and
>> multiple git repo including custom extension developments
>>
>> I also follow the Phabricator development quite closely because we
>> upgrade every couple of weeks
>>
>> I’d be more than happy to help maintain the phab instance for LLVM
>>
>
> Congrats. You're now an admin :)
> (and thanks!!)
>
> I'll figure out who easy it is to give access to our GCE to external
> folks, given everything on it is OSS stuff.
>
>
>>
>> MyDeveloperDay
>>
>> On Fri, 31 May 2019 at 09:19, Manuel Klimek via llvm-dev <
>> llvm-dev at lists.llvm.org> wrote:
>>
>>>
>>>
>>> On Fri, May 31, 2019 at 10:11 AM Aaron Ballman <aaron.ballman at gmail.com>
>>> wrote:
>>>
>>>>
>>>>
>>>> On Fri, May 31, 2019, 10:02 AM Roman Lebedev via llvm-dev <
>>>> llvm-dev at lists.llvm.org> wrote:
>>>>
>>>>> On Fri, May 31, 2019 at 10:55 AM Manuel Klimek via llvm-dev
>>>>> <llvm-dev at lists.llvm.org> wrote:
>>>>> >
>>>>> > We should be able to control the noise of these
>>>>>
>>>>> >, but I also wonder whether we can switch to github reviews as part
>>>>> of the git move :)
>>>>> (Provocative offtopic. (I personally hope that never ever happens.))
>>>>>
>>>>
>>>> Strong +1 to not switching away from phab.
>>>>
>>>
>>> Aaron, do you have admin on phab yet? If yes, would you mind to config
>>> the notifications?
>>> (honestly, part of my comment was trying to figure out who wants it so
>>> badly that they'd be willing to help with maintenance - I have admin bits
>>> to hand out :)
>>>
>>>
>>>>
>>>> ~Aaron
>>>>
>>>>
>>>>> > (we just lost our long time phab maintainer on the team)
>>>>>
>>>>> > On Fri, May 31, 2019 at 12:44 AM Shoaib Meenai via llvm-dev <
>>>>> llvm-dev at lists.llvm.org> wrote:
>>>>> >>
>>>>> >> I believe (and I believe it was James who pointed this out on IRC)
>>>>> that Phabricator pulls in all refs, and GitHub stores PR commits under
>>>>> refs/pull.
>>>>> >>
>>>>> >> On 5/30/19, 3:37 PM, "llvm-dev on behalf of Tom Stellard via
>>>>> llvm-dev" <llvm-dev-bounces at lists.llvm.org on behalf of
>>>>> llvm-dev at lists.llvm.org> wrote:
>>>>> >>
>>>>> >> On 05/30/2019 10:04 AM, Sachkov, Alexey via llvm-dev wrote:
>>>>> >> > +llvm-dev
>>>>> >> >
>>>>> >> >
>>>>> >> >
>>>>> >> > *From:* cfe-dev [mailto:cfe-dev-bounces at lists.llvm.org] *On
>>>>> Behalf Of *Bader, Alexey via cfe-dev
>>>>> >> > *Sent:* Thursday, May 30, 2019 7:31 PM
>>>>> >> > *To:* clang-dev developer list <cfe-dev at lists.llvm.org>
>>>>> >> > *Subject:* [cfe-dev] FYI: LLVM Phabricactor notifications.
>>>>> >> > *Importance:* Low
>>>>> >> >
>>>>> >> >
>>>>> >> >
>>>>> >> > Hi,
>>>>> >> >
>>>>> >> >
>>>>> >> >
>>>>> >> > I think some of contributors to the Clang received a
>>>>> notifications about some commits done in the past.
>>>>> >> >
>>>>> >> > I wanted to share my thoughts on why it might has happened.
>>>>> >> >
>>>>> >> >
>>>>> >> >
>>>>> >> > I think the commits from this PR
>>>>> https://github.com/llvm/llvm-project/pull/13were pulled by
>>>>> Phabricator (probably with aim to review GitHub pull requests in
>>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=KaCscc77Z-fBuYo2dCuykCeHg35yKQXRwp6uVuIsPos&e=
>>>>> environment).
>>>>> >> >
>>>>> >> >
>>>>> >> >
>>>>> >> > The PR has 2000+ commit, most of which are some old commits
>>>>> from the master branch, and when Phabricator pulled the commits from PR, it
>>>>> sent a notification to the commit author (or committer).
>>>>> >> >
>>>>> >> >
>>>>> >> >
>>>>> >> > Probably we can do something to avoid this situation in the
>>>>> future.
>>>>> >> >
>>>>> >> >
>>>>> >>
>>>>> >> + Manuel, Chandler
>>>>> >>
>>>>> >> Any idea what happened here? Is phabricator setup to
>>>>> automatically import
>>>>> >> pull requests?
>>>>> >>
>>>>> >> -Tom
>>>>> >>
>>>>> >> >
>>>>> >> > Sorry for the inconvenience.
>>>>> >> >
>>>>> >> >
>>>>> >> >
>>>>> >> > Alexey
>>>>> >> >
>>>>> >> >
>>>>> >> >
>>>>> >> >
>>>>> >> >
>>>>> --------------------------------------------------------------------
>>>>> >> > Joint Stock Company Intel A/O
>>>>> >> > Registered legal address: Krylatsky Hills Business Park,
>>>>> >> > 17 Krylatskaya Str., Bldg 4, Moscow 121614,
>>>>> <https://www.google.com/maps/search/17+Krylatskaya+Str.,+Bldg+4,+Moscow+121614,+%0D%0A+%C2%A0+%C2%A0+%C2%A0+Russian+Federation?entry=gmail&source=g>
>>>>>
>>>>> <https://www.google.com/maps/search/17+Krylatskaya+Str.,+Bldg+4,+Moscow+121614,+%0D%0A+%C2%A0+%C2%A0+%C2%A0+Russian+Federation?entry=gmail&source=g>
>>>>> >>
>>>>> <https://www.google.com/maps/search/17+Krylatskaya+Str.,+Bldg+4,+Moscow+121614,+%0D%0A+%C2%A0+%C2%A0+%C2%A0+Russian+Federation?entry=gmail&source=g>>
>>>>> Russian Federation
>>>>> <https://www.google.com/maps/search/17+Krylatskaya+Str.,+Bldg+4,+Moscow+121614,+%0D%0A+%C2%A0+%C2%A0+%C2%A0+Russian+Federation?entry=gmail&source=g>
>>>>> >> >
>>>>> >> > This e-mail and any attachments may contain confidential
>>>>> material for
>>>>> >> > the sole use of the intended recipient(s). Any review or
>>>>> distribution
>>>>> >> > by others is strictly prohibited. If you are not the intended
>>>>> >> > recipient, please contact the sender and delete all copies.
>>>>> >> >
>>>>> >> >
>>>>> >> >
>>>>> >> > _______________________________________________
>>>>> >> > LLVM Developers mailing list
>>>>> >> > llvm-dev at lists.llvm.org
>>>>> >> >
>>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=42V9lvDIvDXSSvzhNIJLw7ddZMt54c2yNRxFpSMppEg&e=
>>>>> >> >
>>>>> >>
>>>>> >> _______________________________________________
>>>>> >> LLVM Developers mailing list
>>>>> >> llvm-dev at lists.llvm.org
>>>>> >>
>>>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Ddev&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=AD-hZ9rLcmVgzhl1TFTAvKbX-nrgHD75y9sqN5zTEsg&s=42V9lvDIvDXSSvzhNIJLw7ddZMt54c2yNRxFpSMppEg&e=
>>>>> >>
>>>>> >>
>>>>> >> _______________________________________________
>>>>> >> LLVM Developers mailing list
>>>>> >> llvm-dev at lists.llvm.org
>>>>> >> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>>>> >
>>>>> > _______________________________________________
>>>>> > LLVM Developers mailing list
>>>>> > llvm-dev at lists.llvm.org
>>>>> > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>>>> _______________________________________________
>>>>> LLVM Developers mailing list
>>>>> llvm-dev at lists.llvm.org
>>>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>>>>
>>>> _______________________________________________
>>> LLVM Developers mailing list
>>> llvm-dev at lists.llvm.org
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>>
>> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20190531/1ec5df13/attachment.html>
More information about the cfe-dev
mailing list