[cfe-dev] [GitHub] RFC: Enforcing no merge commit policy

Roman Lebedev via cfe-dev cfe-dev at lists.llvm.org
Wed Mar 20 07:22:50 PDT 2019


I should not have mentioned PR's in my mail.
Can we please not go off-subject here?

On Wed, Mar 20, 2019 at 5:13 PM James Y Knight <jyknight at google.com> wrote:
>
> Then we should not accept it. What if someone did the same on a phabricator review?
>
> On Wed, Mar 20, 2019 at 2:39 AM Anton Korobeynikov <anton at korobeynikov.info> wrote:
>>
>> > Github PRs are how everyone who is not already super-involved in the llvm project is going to want to contribute changes, and we ought to be as welcoming as possible to such users.
>> Still we'd need some policy & checks here. Say, what if someone will
>> issue a PR to LLVM 4.0 branch? With clear code style violations, etc.
>>
>> --
>> With best regards, Anton Korobeynikov
>> Department of Statistical Modelling, Saint Petersburg State University



More information about the cfe-dev mailing list