[cfe-dev] [Openmp-dev] [GitHub] RFC: Enforcing no merge commit policy

Mehdi AMINI via cfe-dev cfe-dev at lists.llvm.org
Sat Apr 13 16:47:57 PDT 2019


On Tue, Apr 9, 2019 at 12:39 AM David Chisnall via cfe-dev <
cfe-dev at lists.llvm.org> wrote:

> On 09/04/2019 00:32, Tom Stellard via cfe-dev wrote:
> > As a backup plan, I am going to look into implementing option #1, but
> instead
> > of having git-llvm create a pull request, it would push first to a
> staging
> > branch and then push to master if a 'no-merge commit' status checks
> pass.  This
> > is essentially the same flow as using pull requests, but without all the
> > pull request noise.
>
> I don't think that you can enforce this policy on the server side.  You
> could; however, make git-llvm create a pull request and, if the relevant
> checks pass, automatically use the GitHub APIs to do a rebase and merge.
>

I believe you can with:
https://help.github.com/en/articles/enabling-required-status-checks

I don't even think you need to push a branch for this*, the git-llvm script
should be able to perform the required check locally, then issue a REST
call and push to master.

-Mehdi

* on another note, I hope we will *disallow* user branches on the main repo
in favor of forks.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20190413/35eafcd1/attachment.html>


More information about the cfe-dev mailing list