[cfe-dev] [RFC] Add include-what-you-use tool to clang-tools-extra

[Kim Gräsman via cfe-dev]

On Fri, Sep 8, 2017 at 12:26 PM, Manuel Klimek <klimek at google.com> wrote:
> On Fri, Sep 8, 2017 at 11:15 AM Kim Gräsman <kim.grasman at gmail.com> wrote:
>>
>> I'm not sure the most productive way to do that is to start from
>> scratch, though.
>
> I fully agree. My main point is: I don't think putting it into
> clang-tools-extra in its current form is the right approach. I don't know
> any better way to incrementally get it into the form it would need to get
> into clang-tools-extra other than through incremental patches to
> clang-tools-extra, given that many folks just read the mailing list for
> patches, and if we try to go around the usual approach (for example by doing
> reviews in the current location) important feedback / objections might drop
> in only when the full thing goes in in the end.
>
> That said, I perhaps also don't find it super important for iwyu to be in
> clang-tools-extra - it'd most certainly be nice, and make me happy on a
> principled basis, but given the current state of the world, I'd rather wait
> a bit how things play out than try to force it.

Right. The original proposal listed a number of pros and cons, but of
course I'm looking at this mostly from IWYU's perspective.

It would be a great help to us to be closer to Clang, especially when
it comes to packaging and releases -- we spend a lot of our time just
adjusting build systems to keep both in-tree and out-of-tree builds
running smoothly.

We also have a (very informal) API wishlist that's hard to discuss in
a principled way when IWYU is just hanging by the sidelines. I'm
hoping it would be easier with closer proximity, especially if we
could put in some work to help build it out. That would benefit other
Clang tools as well.

Our testing infrastructure is pretty good, but let's be frank: it's not lit.

And the list goes on -- IWYU is built and developed as if part of
Clang, but it's hard to keep up! We're hoping it would be easier for
us, and a net benefit for all, if we just joined the streams.

- Kim