[cfe-dev] [Proposal] Automatically Cc: cfe-commits@ on Clang reviews

Manuel Klimek via cfe-dev cfe-dev at lists.llvm.org
Wed Nov 22 08:23:38 PST 2017


+llvm-dev, so we get wider input :)

Given how unfortunate reviews that are started without cc'ing the right
list are (basically folks need to re-send the review from scratch), I
support this idea.

Ben, couldn't rL still be available for all projects? (and be the main
project for LLVM).


On Tue, Nov 21, 2017 at 5:18 PM Ben Hamilton via cfe-dev <
cfe-dev at lists.llvm.org> wrote:

> OK. I confirmed that Stephan's process to send out cross-repo diffs from
> the monorepo is not affected by my proposal.
>
> tl;dr: https://reviews.llvm.org/D40312 (which was sent out on top of
> D40179 to emulate what happens with a monorepo after my proposal lands).
>
> Steps I took (starting with
> https://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo
> ):
>
> ===
> % git clone https://github.com/llvm-project/llvm-project-20170507/
> llvm-project
> % cd llvm-project
> % cp llvm/.arcconfig .
> % mkdir -p .git/info
> % echo .arcconfig >> .git/info/exclude
> # Manually apply D40179 into the clang-tools-extra directory
> % arc export --revision D40179 --git | patch -d clang-tools-extra -p1
> patching file .arcconfig
> % git diff
> diff --git a/clang-tools-extra/.arcconfig b/clang-tools-extra/.arcconfig
> index f846581763e..d4a00161bce 100644
> --- a/clang-tools-extra/.arcconfig
> +++ b/clang-tools-extra/.arcconfig
> @@ -1,4 +1,4 @@
>  {
> -  "project_id" : "clang-tools-extra",
> +  "repository.callsign" : "CTE",
>    "conduit_uri" : "https://reviews.llvm.org/"
>  }
>  % git commit -a -m "Differential Revision:
> https://reviews.llvm.org/D40179"
>  % echo "Test 1" >> llvm/README.txt
>
>  % echo "Test 2" >> clang-tools-extra/README.txt
>
>  % git commit -a -m "[Test] Monorepo test diff crossing Differential
> repositories"
>  % arc diff --create --reviewers sberg HEAD^
> ===
>
> Ben
>
> On Tue, Nov 21, 2017 at 8:00 AM Stephan Bergmann <sbergman at redhat.com>
> wrote:
>
>> On 11/21/2017 03:41 PM, Ben Hamilton wrote:
>> >  > My understanding was that, while there currently is no official
>> > monorepo, it is at least possible and accepted to send single,
>> > cross-repo patches for review.  That would no longer be possible, right?
>> >
>> > I assume cross-repo patches would be constructed by hand, right? Or do
>> > you mean using the unofficial monorepo from 2016
>> > <https://github.com/joker-eph/llvm-project>?
>>
>> I'm using <https://github.com/llvm-project/llvm-project-20170507> (as
>> advertised at
>> <
>> https://llvm.org/docs/GettingStarted.html#for-developers-to-work-with-a-git-monorepo
>> >),
>> where such a "cross-repo diff" is just a matter of a plain 'git diff'.
>>
>> > An example of an existing cross-repo review in Differential would be
>> > niceā€”do you happen to have one handy?
>>
>> I just happened to file <https://reviews.llvm.org/D40295> a moment ago,
>> spanning clang and compiler-rt.
>>
>> > I think either way, we'd keep the ability to send cross-repo patches to
>> > the top-level LLVM repo just the same way you could today.
>> >
>> > I'll confirm that if you can help me construct an example cross-repo
>> > patch for review.
>>
>> Thanks,
>> Stephan
>>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20171122/16c8b83e/attachment-0001.html>


More information about the cfe-dev mailing list