[cfe-dev] [llvm-dev] a proposed script to help with test-suite programs that output _lots_ of FP numbers

Sebastian Pop via cfe-dev cfe-dev at lists.llvm.org
Thu Sep 29 14:26:23 PDT 2016


On Thu, Sep 29, 2016 at 2:05 PM, Renato Golin <renato.golin at linaro.org> wrote:
> On 29 September 2016 at 19:21, Sebastian Pop <sebpop.llvm at gmail.com> wrote:
>> Cumulating errors is a bad idea.
>> As others have suggested, please prepare a patch that disables
>> fp-contract on those testcases.
>
> No, please, let's not disable things just because they fail.
>
> If the test is not meaningful or if the results are not good, let's
> just change the test in a meaningful way that can work with any FP
> optimisation without changing meaning.
>
> If it does change meaning, it's a bug and we *want* to catch.

These tests are checking the results against a "golden file" output
computed with fp-contract=off.
IMHO the most sensible solution is to continue checking those tests
with the same flag
as at the time when the reference output has been recorded.

Thanks,
Sebastian


More information about the cfe-dev mailing list