[cfe-dev] OpenBSD/arm types

Mark Kettenis via cfe-dev cfe-dev at lists.llvm.org
Mon Sep 19 15:34:15 PDT 2016


> Date: Mon, 19 Sep 2016 22:16:56 +0200
> From: Joerg Sonnenberger via cfe-dev <cfe-dev at lists.llvm.org>
> 
> On Sun, Sep 18, 2016 at 09:43:11PM +0200, Mark Kettenis via cfe-dev wrote:
> > Here is a diff that changes the Preprocessor/init.c test to test for
> > the types which should be the same on all architectures supported by
> > OpenBSD.  I did add a check for the __ELF__ and __OpenBSD__ defines
> > which should be present as well.  I think doing it this way makes a
> > bit more sense than checking a few random platforms, which is what the
> > NetBSD tests currently do.
> 
> It's not a random platform list, it is exhaustive as far as the
> supported platforms go. MIPS(64) is missing from the list as it is not
> yet fully/properly tested as far as NetBSD goes.

That came out a little bit stronger than intended.  All I wanted to
say is that even though NetBSD seems to aim for the same type
consistency across platforms as OpenBSD, there are separate tests for
each platform.  Which appeared sub-optimal in the context of my diff
for OpenBSD.


More information about the cfe-dev mailing list