[cfe-dev] [llvm-dev] [3.8 Release] RC1 has been tagged

Mehdi Amini via cfe-dev cfe-dev at lists.llvm.org
Tue Jan 26 08:53:04 PST 2016


If the test-suite setup with CMake is broken, why not replace the CMake auto-detection of the test-suite with an error?
Something like:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index d96afc465177..918da6f6c945 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -693,11 +693,7 @@ endif()
 
 if( LLVM_INCLUDE_TESTS )
   if(EXISTS ${LLVM_MAIN_SRC_DIR}/projects/test-suite AND TARGET clang)
-    include(LLVMExternalProjectUtils)
-    llvm_ExternalProject_Add(test-suite ${LLVM_MAIN_SRC_DIR}/projects/test-suite
-      USE_TOOLCHAIN
-      EXCLUDE_FROM_ALL
-      NO_INSTALL)
+    message(FATAL_ERROR "The test-suite cannot be built in-tree with CMake at that time")
   endif()
   add_subdirectory(test)
   add_subdirectory(unittests)



— 
Mehdi


> On Jan 26, 2016, at 8:04 AM, James Molloy via cfe-dev <cfe-dev at lists.llvm.org> wrote:
> 
> The test-suite shouldn't be being build with CMake for the release - the CMake system is not yet ready. Have you accidentally checked out the test-suite into /projects? if it's there it will auto-configure.
> 
> James
> 
> On Tue, 26 Jan 2016 at 16:01 Ismail Donmez via cfe-dev <cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>> wrote:
> On Tue, Jan 26, 2016 at 1:56 PM, Nikola Smiljanic via llvm-dev
> <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote:
> > Phase1 fails to build on openSUSE 13.2, can anyone see what's wrong from
> > this log file?
> 
> Something wrong with the test-suite:
> 
> make -f CMakeFiles/test-suite.dir/build.make CMakeFiles/test-suite.dir/depend
> make[2]: Entering directory
> '/home/nikola/rc1/Phase1/Release/llvmCore-3.8.0-rc1.obj'
> CMakeFiles/test-suite.dir/build.make:112: *** target pattern contains
> no '%'.  Stop.
> make[2]: Leaving directory
> '/home/nikola/rc1/Phase1/Release/llvmCore-3.8.0-rc1.obj'
> CMakeFiles/Makefile2:198: recipe for target
> 'CMakeFiles/test-suite.dir/all' failed
> make[1]: *** [CMakeFiles/test-suite.dir/all] Error 2
> make[1]: *** Waiting for unfinished jobs....
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org <mailto:cfe-dev at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev <http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20160126/c315c07f/attachment.html>


More information about the cfe-dev mailing list