[cfe-dev] Making clang::Rewriter friendlier for subclassing

[Manasij Mukherjee]

If you mean to call the base methods anyway, wouldn't it be better to have
a Rewriter object as a member of your class ?


On Thu, May 14, 2015 at 12:20 PM, Eli Bendersky <eliben at google.com> wrote:

> Hi,
>
> Would there be objections to make clang::Rewriter a bit friendlier for
> subclassing by marking some of its methods virtual? In particular
> InsertText, ReplaceText, RemoveText and their variations.
>
> The reason for this is to be able to subclass Rewriter for the purposes of
> logging, debugging and other custom capabilities.
>
> If this sounds reasonable, I'll be happy to implement this.
>
> Thanks in advance,
>
> Eli
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20150514/8285f233/attachment.html>