[cfe-dev] shell-preserves-root is (*almost) always true...kill it?

[Yaron Keren]

Since r179283, internal shell is default on windows (*unless use_lit_shell
= 0), so execute_external = not windows and

# Exclude MSYS due to transforming '/' to 'X:/mingwroot/'.
if not platform.system() in ['Windows'] or not execute_external:
    config.available_features.add('shell-preserves-root')

is really "if not windows or (not not windows)" = "if true" making
shell-preserves-root always true on Windows (unless use_lit_shell = 0).

No tests that require shell-preserves-root are actually disabled now on
WIndows + MSYS2. In this configuration, just one test fails (which really
require shell-preserves-root): darwin-sdkroot.c. This test has no purpose
on windows anyhow and may be disabled. All other tests
with shell-preserves-root do pass on MSYS2 bash.

Does shell-preserves-root serves any purpose now?
Any reason to keep it alive?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20150715/d12815f5/attachment.html>