[cfe-dev] X86 intrinsics running out of IdentifierInfo Builtin IDs

[Benyei, Guy]

Thanks, that sounds reasonable. Let’s see if there is any other input. If no one is opposed to it, we will include this change with the implementation of the new ISA intrinsics.

Thanks
      Guy

From: Reid Kleckner [mailto:rnk at google.com]
Sent: Wednesday, July 01, 2015 20:01
To: Benyei, Guy
Cc: cfe-dev at cs.uiuc.edu
Subject: Re: [cfe-dev] X86 intrinsics running out of IdentifierInfo Builtin IDs

It seems increasingly true that we care less about optimizing for size on 32-bit architectures. On a 64-bit platform, we had 32-bits of padding there already, so we can probably afford the extra space on 32-bit.

On Wed, Jul 1, 2015 at 6:12 AM, Benyei, Guy <guy.benyei at intel.com<mailto:guy.benyei at intel.com>> wrote:
Hi all,
My team is working on adding some more X86 intrinsics to Clang/LLVM, and we are hitting the limit of the number of builtins supported by Clang. The “ObjCOrBuiltinID” field in the IdentifierInfo class is 11 bits wide, which is not sufficient to represent all the new intrinsics, and we are getting the "ID too large for field!" assertion.

The easiest fix seems to be to increase the size of this “ObjCOrBuiltinID” field to 12 bits, but that will make the bitfield in IdentifierInfo 33 bits wide, consuming an additional 32 bits in some architectures for each instance. A quick check shows, that this fix works without any functional regressions, but we have no performance numbers yet.

Please let me know if anyone is opposed to adding this additional bit, or if there are any other concerns/suggestions on this issue.

Thanks
[email_signature_guy_new2]


---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

_______________________________________________
cfe-dev mailing list
cfe-dev at cs.uiuc.edu<mailto:cfe-dev at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20150701/acb6cede/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 24800 bytes
Desc: image001.png
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20150701/acb6cede/attachment.png>