[cfe-dev] Newbie question: phabricator reviewers?!

Andy Gibbs via cfe-dev cfe-dev at lists.llvm.org
Mon Dec 21 01:09:24 PST 2015


Hi,

As a newbie to the world of LLVM's phabricator review process, I have a 
question that seems not to be handled in the official help page 
(http://llvm.org/docs/Phabricator.html).  The question I have is, who should I 
add as a reviewer to my patch?  I assume simply adding cfe-commits only is not 
the correct way?

The patch in question is http://reviews.llvm.org/D15636.  I had a look in 
CODE_OWNERS.TXT, and the obvious choice would have been Richard, but I didn't 
think it right to simply just stick him on the list (I imagine he is busy 
enough!).

What is the correct approach?

Thanks
Andy




More information about the cfe-dev mailing list