[cfe-dev] Does libc++ really need both _LIBCPP_INLINE_VISIBILITY and _LIBCPP_ALWAYS_INLINE?

[Rafael Espíndola via cfe-dev]

>> #define _LIBCPP_INLINE_VISIBILITY __attribute__((__always_inline__))
>> #define _LIBCPP_ALWAYS_INLINE  __attribute__((__visibility__("hidden"),
>> __always_inline__))
>>
>> I'm almost certain this difference is unintentional. However before I remove
>> one in favor of the other I would like to be sure this is the correct thing
>> to do.
>>
>> I would like to find out if:
>>
>> 1.Do visibility attributes have any effect on windows? If not the two
>> definitions are already functionally identical.
>
> Maybe it could affect linkage? Rafael or Reid would probably know.
>
> In any case it looks strange. And does libc++ even have Windows support?


Sorry, no idea what hidden will expand to on COFF.

Cheers,
Rafael