[cfe-dev] [libc++] Porting libc++ to Windows

[Fulvio Esposito]

On 8/5/15 2:29 PM, Eric Fiselier wrote:
 I would prefer phabricator simply because it will get lost on my TODO
 list otherwise. To use phabricator I just run "git diff master" and
 upload that diff to phabricator (assuming your branch in up to date
 with the HEAD of master).

`git diff master -U999` is preferred to make reviews easier.


Jon


 /Eric

 On Wed, Aug 5, 2015 at 3:58 PM, Fulvio Esposito fulvio.esposito at live.it wrote:
 I was using GitHub just because I’ve never used Phabricator. If you can give
 me some pointers I’ll switch to that. I will also squashing the commits.

 Regards,

 Fulvio






 From: David Chisnall
 Sent: 05 August 2015 20:50
 To: Fulvio Esposito
 Cc: clang developer list
 Subject: Re: [cfe-dev] [libc++] Porting libc++ to Windows





 Hi Fulvio,

 I’m happy to do code review on GitHub if that’s easier for you than
 Phabricator, but would you mind creating a branch that is rebased on head
 and has all of the commits squashed, so that I can see a single commit as a
 diff against head?

 Thanks,

 David





 _______________________________________________
 cfe-dev mailing list
 cfe-dev at lists.llvm.org
 http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev

 _______________________________________________
 cfe-dev mailing list
 cfe-dev at lists.llvm.org
 http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev


-- 
Jon Roelofs
jonathan at codesourcery.com
CodeSourcery / Mentor Embedded



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20150805/9520b670/attachment.html>