[cfe-dev] misleading documentation for PPCallbacks::FileSkipped

[Vladimir Voskresensky - Oracle]

Hello Manuel,

I use Firefox.
I tried to edit fields from Solaris and from Ubuntu and failed in both cases.

Hope it helps,
Vladimir.

On 04/20/15 06:20 PM, Manuel Klimek wrote:
>
>
> On Mon, Apr 20, 2015 at 4:35 PM Vladimir Voskresensky 
> <vladimir.voskresensky at oracle.com <mailto:vladimir.voskresensky at oracle.com>> 
> wrote:
>
>     Hello Nikola,
>
>     I've created http://reviews.llvm.org/D9109, but for unknown reason as soon
>     as focus lost "reviewer" or "Subscribers" fields it's content is erased,
>     so I can not add you and cfe list there.
>
>
> What browser are you using?
>
>     Could you update http://reviews.llvm.org/D9109 appropriately.
>
>     Thank you!
>
>     Vladimir.
>
>
>     On 04/18/2015 04:24 AM, Nikola Smiljanic wrote:
>>     Sorry for not telling you earlier, can you please upload this to
>>     Phabricator and CC me?
>>
>>     On Sat, Apr 18, 2015 at 4:43 AM, Vladimir Voskresensky - Oracle
>>     <vladimir.voskresensky at oracle.com
>>     <mailto:vladimir.voskresensky at oracle.com>> wrote:
>>
>>         Hello Nikola,
>>
>>         Please, review and apply attached patch.
>>
>>         Thanks!
>>         Vladimir.
>>
>>         On 04/14/15 11:14 AM, Nikola Smiljanic wrote:
>>>         Looks that way at first glance, feel free to submit a patch as there
>>>         seem to be quite a few places that need updating.
>>>
>>>         On Sat, Apr 4, 2015 at 1:15 AM, Vladimir Voskresensky - Oracle
>>>         <vladimir.voskresensky at oracle.com
>>>         <mailto:vladimir.voskresensky at oracle.com>> wrote:
>>>
>>>             Hello,
>>>
>>>             It looks like the name and documentation of the first parameter
>>>             is incorrect
>>>               virtual void FileSkipped(const FileEntry &ParentFile,
>>>                                        const Token &FilenameTok,
>>>              SrcMgr::CharacteristicKind FileType) {
>>>               }
>>>
>>>             passed ParentFile is in fact SkippedFile.
>>>
>>>             The code from Preprocessor::HandleIncludeDirective which calls
>>>             FileSkipped:
>>>
>>>               // Ask HeaderInfo if we should enter this #include file. If
>>>             not, #including
>>>               // this file will have no effect.
>>>               if (!HeaderInfo.ShouldEnterIncludeFile(File, isImport)) {
>>>                 if (Callbacks)
>>>             Callbacks->FileSkipped(*File, FilenameTok, FileCharacter);
>>>                 return;
>>>               }
>>>
>>>
>>>             Thanks,
>>>             Vladimir.
>>>
>>>             _______________________________________________
>>>             cfe-dev mailing list
>>>             cfe-dev at cs.uiuc.edu <mailto:cfe-dev at cs.uiuc.edu>
>>>             http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>>>
>>>
>>
>>
>>
>>
>>     _______________________________________________
>>     cfe-dev mailing list
>>     cfe-dev at cs.uiuc.edu  <mailto:cfe-dev at cs.uiuc.edu>
>>     http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
>     _______________________________________________
>     cfe-dev mailing list
>     cfe-dev at cs.uiuc.edu <mailto:cfe-dev at cs.uiuc.edu>
>     http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
>
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20150420/3bb0cce5/attachment.html>