[cfe-dev] [PATCH] Correct bit_SSE4* macro names to match gcc.

Matt Turner mattst88 at gmail.com
Thu May 22 20:35:18 PDT 2014


On Thu, May 22, 2014 at 8:24 PM, Chandler Carruth <chandlerc at google.com> wrote:
> We need a test case for this patch at the least.

Seems like test driven development gone too far, but okay. Point me in
the right direction? And test what exactly, that the macro with the
fixed name exists?

> I also wonder if we shouldn't support both names to avoid breaking any code
> that has been written to Clang and never tested with GCC? Supporting both
> names in this particular context seems less onerous than usual.

I'd say no, because it only allows people to write code that's
incompatible with the original cpuid.h implementation provided by gcc.



More information about the cfe-dev mailing list