[cfe-dev] Should dump methods be LLVM_ATTRIBUTE_USED only in debug builds?
chandlerc at google.com
Fri Jan 3 11:41:55 PST 2014
On Fri, Jan 3, 2014 at 2:03 PM, Nico Weber <thakis at chromium.org> wrote:
> On Fri, Jan 3, 2014 at 10:15 AM, Nico Weber <thakis at chromium.org> wrote:
>> Ok, sounds like it's not clear if folks want to have dump methods behind
>> #ifdef !NDEBUG. Maybe we don't have to resolve that part in this thread
>> Is there any opposition to replacing the attributes on just the dump
>> methods with LLVM_DUMP_METHOD? That's a subset of Chandler's change and I
>> think also what Alp's diff is.
>> …which is effectively Alp's patch I suppose. So maybe we could land that
> for now and then discuss whether to put dump() methods in !NDEBUG at some
> other point?
I'd like to actually see the patch rather than talk in the hypothetical.
Maybe I misunderstood, but I thought it also moved the attribute to the
definition? I don't understand why that's relevant yet (which is why maybe
I've misunderstood what was happening). I've asked what the bug was that
this addressed. My reading of the spec for the attribute seems to indicate
that there is no difference....
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-dev