[cfe-dev] Clang fails to diagnose static_cast<> issue in member function of class template

[Mark Lacey]

My commit earlier broke the VC++ build, and I’ve reduced the code to the following (at the bottom).

I’m not sure if this is something Clang should diagnose, something VC++ shouldn’t diagnose, or if both behaviors are considered correct.

Clang only emits a diagnostic if there is a function body that declares a value of Derived<Other> - it doesn’t emit a diagnostic for member variables of type Derived<Other>. Should it eagerly diagnose this?

Another very odd thing I noticed is that even with a function body with a variable of type Derived<Other>, Clang fails to emit a diagnostic if Derived::Foo is non-virtual (uncomment Bar() below and comment-out “virtual” before Foo()).

Mark




class Base {
public:
  class Inner {};
};

template<class T> class Derived : public Base {
private:
  // Clang only emits a diagnostic if this is virtual.
  //
  // error: static_cast from 'Base::Inner *' to 'Other *' is not allowed
  //    T *TN = static_cast<T *>(N);
  virtual
  void Foo(Inner *N) {
    T *TN = static_cast<T *>(N);
  }
};

class Other;

class Container {
  Derived<Other> Data;
  // Clang only emits a diagnostic if there is a function body using
  // Dervied<Other>, not if there is simply a member declaration using
  // Derived<Other>.
  // void Bar() { Derived<Other> D; }
};