[cfe-dev] Proposed change to newFrontendActionFactory() requirements

[Vane, Edwin]

I take this back. Patch forthcoming for a less invasive approach.

> -----Original Message-----
> From: cfe-dev-bounces at cs.uiuc.edu [mailto:cfe-dev-bounces at cs.uiuc.edu] On
> Behalf Of Vane, Edwin
> Sent: Monday, May 27, 2013 12:36 PM
> To: Clang Dev List (cfe-dev at cs.uiuc.edu)
> Subject: [cfe-dev] Proposed change to newFrontendActionFactory()
> requirements
> 
> Hi all,
> 
> Currently, newFrontendActionFactory(Arg) requires Arg implement a function
> called newASTConsumer(). I'd like to change this requirement slightly and have
> newASTConsumer() take a pointer to a CompilerInstance like this:
> 
> ASTConsumer *newASTConsumer(const CompilerInstance *CI);
> 
> The goal is to give the created ASTConsumer access to the CompilerInstance and
> anything it creates, the Preprocessor object in particular. I figured this was
> useful enough to warrant breaking current users of newASTConsumer. I'll fix any
> breakages in clang and clang-tools-extra.
> 
> Any objections? Any suggestions for alternate implementations? E.g. should I
> instead provide an alternate function for newFrontendActionFactory()?
> 
> --
> Edwin Vane
>   Software Developer
>   Intel of Canada, Inc.
> 
> 
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev