[cfe-dev] [libcxx] Problem with quick_exit test

Howard Hinnant hhinnant at apple.com
Fri May 10 10:37:43 PDT 2013


On May 9, 2013, at 8:17 AM, İsmail Dönmez <ismail at donmez.ws> wrote:

> 
> Hi,
> 
> On Wed, May 8, 2013 at 7:16 PM, Howard Hinnant <hhinnant at apple.com> wrote:
> 
> On May 8, 2013, at 6:21 AM, İsmail Dönmez <ismail at donmez.ws> wrote:
> 
> > Hi,
> >
> > test/language.support/support.start.term/quick_exit.pass.cpp uses std::at_quick_exit() to test quick exit functionality. But looking at include/cstdlib header inside libcxx at_quick_exit function is not defined in the std namespace.
> >
> > Changing the test to use at_quick_exit(f) without the namespace fixes the build for me.
> >
> > Is this an oversight or am I missing something?
> 
> It sounds like <__config> needs to turn on _LIBCPP_HAS_QUICK_EXIT for your platform.  Currently <__config> says:
> 
> #if defined(__FreeBSD__) && (__ISO_C_VISIBLE >= 2011 || __cplusplus >= 201103L)
> #define _LIBCPP_HAS_QUICK_EXIT
> 
> Perhaps you could test & submit a patch to fix this?
> 
> Attached patch fixes the test on Linux for me.
> 
> Thanks,
> ismail
>  
> <quick_exit_linux.patch>

Thanks, Committed revision 181612.

Howard





More information about the cfe-dev mailing list