[cfe-dev] r176987 - Attempt to fix test.

Bill Wendling wendling at apple.com
Wed Mar 13 15:46:53 PDT 2013


On Mar 13, 2013, at 3:43 PM, Reed Kotler <rkotler at mips.com> wrote:

> On 03/13/2013 03:29 PM, Bill Wendling wrote:
>> Author: void
>> Date: Wed Mar 13 17:29:26 2013
>> New Revision: 176987
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=176987&view=rev
>> Log:
>> Attempt to fix test.
>> 
>> Modified:
>>     cfe/trunk/test/CodeGen/mips16-attr.c
>> 
>> Modified: cfe/trunk/test/CodeGen/mips16-attr.c
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/mips16-attr.c?rev=176987&r1=176986&r2=176987&view=diff
>> ==============================================================================
>> --- cfe/trunk/test/CodeGen/mips16-attr.c (original)
>> +++ cfe/trunk/test/CodeGen/mips16-attr.c Wed Mar 13 17:29:26 2013
>> @@ -11,7 +11,7 @@ void __attribute__((nomips16)) nofoo (vo
>> 
>>  // CHECK: define void @nofoo() [[NOMIPS16:#[0-9]+]]
>> 
>> -// CHECK: attributes [[MIPS16]] = { nounwind "fp-contract-model"="standard" "mips16" {{.*}} }
>> +// CHECK: attributes [[MIPS16]] = { nounwind "mips16" {{.*}} }
>> 
>> -// CHECK: attributes [[NOMIPS16]]  = { nounwind "fp-contract-model"="standard" "nomips16" {{.*}} }
>> +// CHECK: attributes [[NOMIPS16]]  = { nounwind "nomips16" {{.*}} }
>> 
> Hmmm... did i mess up here?
> 
Nope. It was me.

-bw

> really we just need to check for the presence of "mips16" or "nomips16".
> 
> can we just prefix those strings with a wildcard?
> 
> I was copying the style of some other tests.
> 
> Reed
> 




More information about the cfe-dev mailing list