[cfe-dev] [PATCH 2/2] Thread-safety: Add test for -Wthread-safety check for C.

Alex Wang alexw at nicira.com
Fri Jul 26 09:32:59 PDT 2013


Hey David,

Thanks for the comments,

On Fri, Jul 26, 2013 at 2:41 AM, David Chisnall <David.Chisnall at cl.cam.ac.uk
> wrote:

> Yes, that's the sort of thing.  c_thread_safety_attributes would probably
> be a bit more in keeping with the naming convention
> for __has_feature entries.
>

Great! ;D
I attach the entire patch again with this reply.

On a mostly unrelated issue, we can do clang -E -dM to find out the list of
> predefined macros, but the only way of finding the valid __has_feature()
> and __has_extension() values that I know of is to read the source code.  It
> would be good if there was some command line option to output all of
> these...
>

I can hack on this over my spare time. Right now, we eagerly look forward
to having "c_thread_safety_attributes". Is there anything else you think
required for applying the patch?

Kind Regards,
Alex Wang,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20130726/f2e111fa/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: c_thread_safety_attributes.diff
Type: application/octet-stream
Size: 5778 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20130726/f2e111fa/attachment.obj>


More information about the cfe-dev mailing list