[cfe-dev] Can we nuke SetUpBuildDumpLog?

[Daniel Dunbar]

On Jan 4, 2013, at 10:48 AM, Chris Lattner <clattner at apple.com> wrote:

> 
> On Jan 4, 2013, at 10:04 AM, Jordan Rose <jordan_rose at apple.com> wrote:
> 
>> To help the discussion keep moving:
>> 
>>   implement a new clang-cc option -dump-build-information=filename which cause
>>   compiler to dump random stuff from the build into the file.  Right now this
>>   amounts to dumping command line arguments and diagnostics to the file.
>> 
>>   The idea is that you can set an envvar, do a world build of an OS, then grep
>>   through all the logs for interesting things or something.
>> 
>>   Daniel, please wire the driver up to do something with this.
> 
> 
> I don't remember that at all, and have no attachment to it.  Daniel, do you remember what this was about, and whether it is used at all?

It's not used, it can be removed. I think I asked for it at some point but never wrote anything else that used it.

 - Daniel

> 
> -Chris
> 
>> 
>> 
>> On Jan 4, 2013, at 9:31 , Chris Lattner <sabre at nondot.org> wrote:
>> 
>>> I don't remember adding this, and with svn down I can't see the commit message.
>>> 
>>> -Chris
>>> 
>>> On Jan 3, 2013, at 10:25 PM, Sean Silva <silvas at purdue.edu> wrote:
>>> 
>>>> Hi Chris, I noticed that in r69386 you introduced a "build dump"
>>>> functionality. Is that still used? if not I'd like to nuke it because
>>>> it is causing argc/argv to leak down into the library code. E.g.
>>>> argc/argv are required arguments to
>>>> CompilerInstance::createDiagnostics solely for the purpose of being
>>>> passed to SetUpBuildDumpLog().
>>>> 
>>>> -- Sean Silva
>>> 
>>> _______________________________________________
>>> cfe-dev mailing list
>>> cfe-dev at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>> 
>> _______________________________________________
>> cfe-dev mailing list
>> cfe-dev at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>