[cfe-dev] [LLVMdev] Phabricator email

[Alp Toker]

On 11/12/2013 17:01, Manuel Klimek wrote:
> On Wed, Dec 11, 2013 at 5:52 PM, Daniel Sanders 
> <Daniel.Sanders at imgtec.com <mailto:Daniel.Sanders at imgtec.com>> wrote:
>
>     I'm not getting the error email you mention, but I have noticed it
>     silently dropping replies (including my own on occasion). I
>     haven't spotted anything the missing replies have in common.
>
>
> Dropping replies from the web interface or the mail interface?
> Also: does "dropping replies" mean that an email reply doesn't show up 
> in the phab interface? (that's currently "working as intended", until 
> we find enough time to write a parser for inline comment replies in mails)

Hi Manuel,

I noticed a few contributors have been landing patches without 
responding to my review comments.

On occasion I had to revert or fix the build after buggy patches were 
landed that didn't take on board review suggestions. In these cases I've 
had a stern word with the patch author because it takes time to review 
each patch and ignoring them is not on.

Looking back I see these patches were posted to the list from 
chandlerc.com -- could it be that the contributors just weren't seeing 
my review comments to begin with?

In fact, looks like something similar happened earlier today on the 
thread "[PATCH] Support Android NDK (which has neither futimes nor 
futimens)" -- in this case however Neil was brilliant and took the 
initiative to sync my email review to his chandlerc.com account.

Alp.


>
> For the rest of the errors we've now got an idea about the root cause, 
> and work is going on upstream to fix it (plus, we're looking for a 
> workaround)
>
> Cheers,
> /Manuel
>
>
>     The web interface did just pop up with this though:
>             Unhandled Exception ("Exception")
>             Failed to proc_open(): proc_open(): fork failed - Cannot
>     allocate memory
>
>     > -----Original Message-----
>     > From: llvmdev-bounces at cs.uiuc.edu
>     <mailto:llvmdev-bounces at cs.uiuc.edu>
>     [mailto:llvmdev-bounces at cs.uiuc.edu
>     <mailto:llvmdev-bounces at cs.uiuc.edu>]
>     > On Behalf Of Renato Golin
>     > Sent: 11 December 2013 13:51
>     > To: LLVM Dev; Clang Dev
>     > Subject: [LLVMdev] Phabricator email
>     >
>     > Hi folks,
>     >
>     > I seem to be getting an error on every reply to a Phabricator
>     auto-generated
>     > email, is this happening to everyone? I've seen comments from
>     others not
>     > registering on it, so I'm assuming this is global.
>     >
>     > This means two things:
>     >
>     > 1. Phabricator is not catching all replies, which means we have
>     an incomplete
>     > picture on it, bad for reviews, but at least the info is stored
>     in the lists
>     > archives.
>     >
>     > 2. Every one is getting an annoying Mailer Daemon Error on every
>     reply. ;)
>     >
>     > Can we get that fixed, or disable the feature, pls?
>     >
>     > cheers,
>     > --renato
>     > _______________________________________________
>     > LLVM Developers mailing list
>     > LLVMdev at cs.uiuc.edu <mailto:LLVMdev at cs.uiuc.edu>
>     http://llvm.cs.uiuc.edu
>     > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>
>     _______________________________________________
>     cfe-dev mailing list
>     cfe-dev at cs.uiuc.edu <mailto:cfe-dev at cs.uiuc.edu>
>     http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

-- 
http://www.nuanti.com
the browser experts