[cfe-dev] Explicit warning diagnostic flags for groups

Dmitri Gribenko gribozavr at gmail.com
Tue Aug 13 01:42:54 PDT 2013


On Mon, Aug 12, 2013 at 10:30 PM, Peter N Lewis <peter at stairways.com.au> wrote:
> I'm happy to put some effort in to the grunge work of doing this if someone more familiar with clang can set me on the right path as to what else needs to be done and what process is needed for submitting the patches, and presuming this is something that will be accepted into clang, and thus eventually work its way into Xcode.

Hi Peter,

This change looks correct.  There are two points to consider:
* choice of the option name.  Does GCC have a similar option?  Does
GCC have a name for this extension in the documentation?
* this change needs tests.  You can model tests for this option based
on this example:

http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/warn-static-const-float.cpp?revision=173841&view=markup

The new test file should go into the same directory as the example.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/




More information about the cfe-dev mailing list