[cfe-dev] clang r163717 (right now) not buildable? (asan_report.cc:282)

[David Blaikie]

On Thu, Sep 13, 2012 at 3:20 AM, Alexey Samsonov <samsonov at google.com> wrote:
>
>
> On Wed, Sep 12, 2012 at 8:27 PM, David Blaikie <dblaikie at gmail.com> wrote:
>>
>> On Wed, Sep 12, 2012 at 9:14 AM, Marshall Clow <mclow.lists at gmail.com>
>> wrote:
>> > On Sep 12, 2012, at 9:00 AM, Sean McBride <sean at rogue-research.com>
>> > wrote:
>> >
>> >> Hi all,
>> >>
>> >> I'm doing a pretty plain CMake build of clang, and it seems to not be
>> >> buildable, giving (on 2 machines):
>> >>
>> >>
>> >> [ 15%] Building CXX object
>> >> projects/compiler-rt/lib/asan/CMakeFiles/clang_rt.asan_osx_dynamic.dir/asan_report.cc.o
>> >> [ 15%] /llvm/llvm/projects/compiler-rt/lib/asan/asan_report.cc:282:1:
>> >> error: function declared 'noreturn' should not return
>> >> [-Werror,-Winvalid-noreturn]
>> >> }
>> >> ^
>> >> 1 error generated.
>> >> make[2]: ***
>> >> [projects/compiler-rt/lib/asan/CMakeFiles/clang_rt.asan_osx_dynamic.dir/asan_report.cc.o]
>> >> Error 1
>> >>
>> >> Any one else seeing this?
>> >
>> > Yes, I'm seeing it too.
>>
>> I guess this might've been what Daniel Dunbar was trying to suppress
>> the other day.
>
>
> Yeah, the problem is that old Clang (3.0 is also considered "old" here)
> incorrectly produces -Winvalid-noreturn
> if a function has local variable with noreturn destructor.
>
> Yesterday we've added -Werror to default compile flags for AddressSanitizer
> runtime,

Ah, that would do it.

> so your build breaks there.
> Probably it's not the best idea: as David mentions, developers may use
> different compilers. We may break many
> of them if their weird (or old) compiler produces any kind of warning in
> ASan code. I'm removing -Werror now.

In the CMake build (& I think the Make build too) at the LLVM level
there's a cmake/configure option for building the whole project as
with -Werror. That's probably the right place for this option (& most
other diagnostic flags, etc, ideally) to live - at some point I want
to bring up a -Werror buildbot (or add it to one of the existing
builders - probably on in a phase2 build) to make this a bit easier to
maintain.

- David

>
>>
>>
>> What version of clang are you using to build?
>>
>> - David
>>
>> >
>> > -- Marshall
>> >
>> > Marshall Clow     Idio Software   <mailto:mclow.lists at gmail.com>
>> >
>> > A.D. 1517: Martin Luther nails his 95 Theses to the church door and is
>> > promptly moderated down to (-1, Flamebait).
>> >         -- Yu Suzuki
>> >
>> >
>> > _______________________________________________
>> > cfe-dev mailing list
>> > cfe-dev at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>> _______________________________________________
>> cfe-dev mailing list
>> cfe-dev at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
>
>
>
> --
> Alexey Samsonov, MSK
>