[cfe-dev] RFC: put commit messages in *-commits subject lines?
clattner at apple.com
Thu Nov 15 17:47:08 PST 2012
On Nov 15, 2012, at 2:28 PM, Chandler Carruth <chandlerc at google.com> wrote:
>> [cfe-commits] r167788 - in /cfe/trunk: lib/Analysis/CFG.cpp test/Analysis/dead-stores.cpp
>> [cfe-commits] r167788 - Fix bad CFG construction bug when handling C++ 'try' statements.
>> The first gives me just enough information (in my abbreviated mesage list window) to see that there was a change to Clang's Analysis library; if I look at the whole subject, I can see what files were changed (or the first few, at least). But the second actually tells me what changed, and whether or not it affects me.
>> Having this form will also encourage people to put a useful summary in the first line of their commit, which is useful for anyone viewing history (especially git users, where the one-line summary is very common).
>> Is there a reason we currently prefer files to log messages?
> I suspect not. I would much prefer your suggestion. If you can
> implement the fix to our scripts (and get Tanya or Chris or Anton to
> give you access), I would be thrilled.
I'm in favor of it. Of course, the truly awesomest thing would be something like:
[cfe-commits] r167788 - [lib/Analysis] Fix bad CFG construction bug when handling C++ 'try' statements.
Even if it required some heuristics and horrible hackery in the commit script, it would be worth it.
More information about the cfe-dev