[cfe-dev] should -Wimplicit-fallthrough require C++11?

Ted Kremenek kremenek at apple.com
Mon Nov 12 13:21:50 PST 2012

On Nov 12, 2012, at 9:47 AM, Chris Lattner <clattner at apple.com> wrote:

>> For my 2c: This warning was only added because we had a way to
>> annotate. In contexts where there is no such annotation the warning
>> doesn't really meet Clang's bar. Rather than forcing people to turn
>> this warning off depending on what they are compiling I think it makes
>> sense for it to be a no-op in any language variant where we don't
>> currently have an annotation mechanism.
>> (this means, imho, for the 3.2 release, we should do as Ted started &
>> have this disabled in both C and C++98 - unless someone's going to
>> whip up the annotation device necessary for those languages in very
>> short order (yes, I realize we've still got weeks until 3.2 actually
>> releases, but I don't see sufficient benefit to rushing through such a
>> change))
> I completely agree - that's the right thing for the 3.2 release.

I agree as well.  I have re-implemented this restriction in r167749, but further restricted the warning only to C++11.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20121112/0acb2a6d/attachment.html>

More information about the cfe-dev mailing list