[cfe-dev] cindex.py & cmake builds of clang

[Michael Spencer]

On Thu, May 10, 2012 at 12:49 AM, Manuel Klimek <klimek at google.com> wrote:
> On Thu, May 10, 2012 at 9:25 AM, David Röthlisberger <david at rothlis.net> wrote:
>> On 9 May 2012, at 08:39, Anders Waldenborg wrote:
>>> On Mon, May 07, 2012 at 01:30:18PM +0200, Arnaud de Grandmaison wrote:
>>>> When building clang using cmake, libclang is actually named
>>>> 'liblibclang' to avoid a file collision on Windows.
>>>
>>> I not sure I fully understand all the details of this issue, but I
>>> think a way to solve the clang.dll collission issue would be to simply
>>> rename libclang.
>>
>>
>> We can always consider this at a later date but right now we are not going to rename libclang because of a build system bug that we already know how to fix.
>>
>> Here is a summary of my understanding of the matter:
>>
>> 1. libclang python bindings don't work on Unixes if libclang was build with cmake.
>> 2. Arnaud submitted a patch to the cmake build system (his second patch in this thread, sent on 2012-05-08). Arnaud tested it on Linux.
>> 3. Manuel tested it on Windows and confirmed that it worked, but he is not a heavy Windows user.
>> 4. WE ARE WAITING FOR WINDOWS USERS TO TEST THE PATCH -- PLEASE HELP. We need you to confirm that with this patch it still builds libclang.dll on Windows (instead of clang.dll, which causes a conflict with clang.exe).
>
> I have verified that it builds libclang.dll on Windows - I want the
> opinion of a windows dev (cc'ed Michael) because it looks to me like
> in the thread that you cite there were concerns raised about how
> windows devs integrate libclang into their projects - so it was more
> about the change in the CMakeLists.txt then about any possible side
> effects.
>
> Cheers,
> /Manuel

I have not tested this patch, nor am I familiar with libclang. But as
a CMake user that links to external libraries, as long as
find_package(clang) works on all platforms, it's good.

- Michael Spencer

>>
>> This is an issue that has caused repeated confusion over the last year.† An entire year ago people were claiming to have a solution but no concrete patch was ever submitted. Now Arnaud has submitted a patch and it would be nice to give this the final push so we can get it committed once and for all.
>>
>> † See the mailing list threads linked to in http://llvm.org/bugs/show_bug.cgi?id=12620#c0
>>
>> Thanks,
>> Dave.