[cfe-dev] [PATCH] Fix clang test failures on MIPS

Manuel Klimek klimek at google.com
Wed May 9 00:37:50 PDT 2012

On Tue, May 8, 2012 at 11:19 PM, Simon Atanasyan <satanasyan at mips.com> wrote:
> On Wed, May 9, 2012 at 1:06 AM, Manuel Klimek <klimek at google.com> wrote:
>> Generally looks good now, two more things to consider:
>> 1. I think we should add a comment about the default setting for the
>> adjuster in the ClangTool class comment
> OK. I will do.
>> 2. How do we test this? I assume all tests still run with
>> -fsynatx-only; I'm not sure whether there's a good way to make sure
>> that code generation has not been run, apart from basically making the
>> output directory unwritable; I'm also fine with letting this in as is,
>> and adding tests when we add more adjustments...
> I do not know how to check the adding -fsynatx-only option explicitly.
> But we can create a test that puts -no-integrated-as options to the
> compile_commands.json file. With that option clang++ always runs two
> jobs on all platforms and we can check that clang-check works
> correctly. Thoughts?

While Chandler seems to have understood the idea, I'm still slightly
confused in what the test would look like - perhaps I need to see
it... :)

Also, I think this would test that the mechanism for setting adjusters
works - in my opinion it's more important to have a smoke test for the
syntax-only default case first (which will not ensure that we're able
to change the adjuster, but that the default adjuster works the way we
want it to).

That is, while I think more specific tests are valuable and adding
them will make me happy, I'd try to come up with a test that checks
the current fsyntax-only behavior first.


More information about the cfe-dev mailing list