[cfe-dev] [PATCH] Fix clang test failures on MIPS

Simon Atanasyan satanasyan at mips.com
Fri May 4 12:56:36 PDT 2012


On Fri, May 4, 2012 at 7:39 PM, Manuel Klimek <klimek at google.com> wrote:
> I haven't put too much thought into the interface yet, but I'd imagine
> something along the lines of
> class ArgumentAdjuster {
> public:
>  vector<std::string> Adjust(const vector<std::string> &Arguments) = 0;
> };
>
> class ClangSyntaxOnlyAdjuster : public ArgumentAdjuster { ... };
>
> Then, for people who have command lines that are for gcc for some reasons:
> class GccToClangAdjuster : public ArgumentAdjuster { ... };
>
> Then we can install a ClangSyntaxOnlyAdjuster per default and add a
> method to ClangTool:
> void setArgumentAdjuster(ArgumentAdjuster *Adjuster);
>
> I think the argument adjusting is orthogonal to the tool, so I'd
> rather avoid inheritance on the ClangTool level.

Now I see your point and like this approach. I will implement and send
a patch for review.

--
Simon




More information about the cfe-dev mailing list