[cfe-dev] [PATCH] Fix clang test failures on MIPS

Simon Atanasyan satanasyan at mips.com
Thu May 3 12:59:01 PDT 2012


On Thu, May 3, 2012 at 10:40 AM, Chandler Carruth <chandlerc at google.com> wrote:
> On Wed, May 2, 2012 at 5:29 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
>>
>> > Clang :: Tooling/clang-check.cpp
>> > Clang :: Tooling/clang-check-pwd.cpp
>> > Clang :: Tooling/clang-check-args.cpp
>> > Clang :: Tooling/clang-check-builtin-headers.cpp
>> >
>> > These tests expect that clang driver runs exactly one compiler job, but
>> > integrated assembler is turned off on MIPS by default and the driver
>> > runs
>> > two jobs. I suggest to add "mips" to the XFAIL list for these tests.
>>
>> Okay, but please add a comment noting why you're XFAILing it on MIPS.
>
>
> FWIW, I think this is a real bug that we should fix. Integrated assembler
> shouldn't impact these tools, there is probably something we're failing te
> set up correctly in the driver and invocation.
>
> I've CC-ed Manuel. We should be able to reproduce this by actively using the
> MIPS triple.

Do you suggest to keep these test failed while the bug is not fixed?
It's not a problem - just want to clarify.

By the way, if somebody give me a short intro to the tooling library
and "clang-check" tool, I would be happy to investigate the bug and
probably fix it.

--
Simon



More information about the cfe-dev mailing list