[cfe-dev] [PATCH] Fix clang test failures on MIPS

Simon Atanasyan satanasyan at mips.com
Thu May 3 12:50:16 PDT 2012

On Thu, May 3, 2012 at 4:29 AM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Wed, May 2, 2012 at 3:04 PM, Simon Atanasyan <satanasyan at mips.com> wrote:
>> Clang :: Preprocessor/mmx.c
>> Clang :: Preprocessor/predefined-arch-macros.c
>> These test check definitions of various i386..x86-64 platforms specific
>> macros. I suggest to add "mips" to the XFAIL list for these tests.
> For those two tests, could you just force an appropriate triple with
> -ccc-host-triple?

Yes, it is possible. The appropriate patch "tgt-force.patch" is
attached to this mail. But I'm not absolutely sure that this approach
is correct. If we pass a target triple explicitly, we check predefined
macros on that target only. If we do not pass a target triple, we
check predefined macros on each different target where we run the test

But if you do not see any problem here and "tgt-force.patch" is okay,
I will commit it.

>> Clang :: Driver/debug-options-as.c
>> This test depends on integrated assembler. I suggest to turn it on
>> explicitly by the "-integrated-as" option.
> Okay.

Commited at r156063.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: tgt-force.patch
Type: application/octet-stream
Size: 24905 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20120503/f995d612/attachment.obj>

More information about the cfe-dev mailing list