[cfe-dev] [PATCH] Fix clang test failures on MIPS

Eli Friedman eli.friedman at gmail.com
Wed May 2 17:29:09 PDT 2012

On Wed, May 2, 2012 at 3:04 PM, Simon Atanasyan <satanasyan at mips.com> wrote:
> Hi,
> The following clang test cases are failed on MIPS. As far as I can see the
> same tests are failed on ARM as well
> (http://lab.llvm.org:8011/builders/clang-native-arm-cortex-a9/builds/1762/steps/test-clang/logs/fail).
> The attached patch fixes some tests and marks others as "expected fail" on
> MIPS. Could you please review the patch?
> Clang :: Preprocessor/mmx.c
> Clang :: Preprocessor/predefined-arch-macros.c
> These test check definitions of various i386..x86-64 platforms specific
> macros. I suggest to add "mips" to the XFAIL list for these tests.

For those two tests, could you just force an appropriate triple with

> Clang :: Driver/debug-options-as.c
> This test depends on integrated assembler. I suggest to turn it on
> explicitly by the "-integrated-as" option.


> Clang :: Tooling/clang-check.cpp
> Clang :: Tooling/clang-check-pwd.cpp
> Clang :: Tooling/clang-check-args.cpp
> Clang :: Tooling/clang-check-builtin-headers.cpp
> These tests expect that clang driver runs exactly one compiler job, but
> integrated assembler is turned off on MIPS by default and the driver runs
> two jobs. I suggest to add "mips" to the XFAIL list for these tests.

Okay, but please add a comment noting why you're XFAILing it on MIPS.


More information about the cfe-dev mailing list