[cfe-dev] [PATCH] OpenCL 1.2 storage class specifiers and errors

[Tanya Lattner]

On Jun 15, 2012, at 2:38 AM, Anton Lokhmotov <Anton.Lokhmotov at arm.com> wrote:

>> Alright, since this proved to take 5 minutes (go Clang), I just did it
>> because I don't want to be held up since I have a bunch of stuff I'm
>> trying to push out.
> Nice, thanks.  
> 
> One comment.  To enable using OpenCLVersion as Guy suggested:
> 
>>> if (getLangOpts().OpenCLVersion >= 120 && SC == SC_Static &&
> 
> you need to ensure that Opts.OpenCLVersion is initialised even when
> Opts.OpenCL is 0, e.g.:
> 
>  LangOpts.OpenCLVersion = 0;
>  ...
>  if (LangStd == LangStandard::lang_opencl) {

The default is 0, it should already be initialized to that regardless of what OpenCL is.

> 
> And a niggle in descriptions: "OpenCL Version" -> "OpenCL version"?

Ok.

-Tanya

> 
> Thanks,
> Anton.
> 
> 
>