[cfe-dev] Fix for preprocessor CommentHandler bug

David Blaikie dblaikie at gmail.com
Tue Jun 12 09:31:12 PDT 2012

> Following hot on the heels of my previous preprocessor patch, here is one
> that solves issues related to the fact that the CommentHandler interface is
> not invoked if comments follow #else and #endif preprocessor directives,
> since it can be that the preprocessor is still in skip (i.e. raw) mode while
> processing the directive line.
> This fix solves this problem by bringing the preprocessor out of raw mode
> while it processes to the end of the directive line.
> The patch causes no test-suite regressions.

<clippy>It looks like you're trying to fix a bug - would you like to
include a test case?</clippy>

& is this a fix for: http://llvm.org/bugs/show_bug.cgi?id=13065 by
chance? I'm curious what caused the bug as I'd assumed it was due to
my commit ( https://llvm.org/svn/llvm-project/cfe/trunk@158093 ). But
judging by the fix, that might not be the case.

- David

More information about the cfe-dev mailing list