[cfe-dev] [llvm-commits] [PATCH] add x32 psABI support

Anton Korobeynikov anton at korobeynikov.info
Fri Jun 8 00:06:26 PDT 2012

Hello Michael,

> Anyone got chance to review the patch adding X32 psABI support?
LLVM patch is quite big to review it alone. Will you please split it
into parts? E.g., as it seems to me:

1. Configure-related things (+Triple, etc)
2. MC changes
3. Codegen changes (is possible, split here too)

Also, it seems you're totally lacking *any* tests. This means that x32
being the "poor sister" here can quickly become bitrot'ed.
Please include ones for:

1. clang driver changes
2. clang ABI bits
3. LLVM codegen


With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University

More information about the cfe-dev mailing list