[cfe-dev] New warning for mismatched include case
clattner at apple.com
Fri Jul 27 11:02:05 PDT 2012
On Jul 27, 2012, at 10:13 AM, Jason Haslam wrote:
>> I wrote a little script to generate a torture test for this warning like I proposed before. It consists of a source file with 4096 different #includes in 64 directories where each directory contains an additional 4096 files. As expected, it is many times slower with the warning enabled than without on the existing implementation. It goes from .08 seconds without the warning up to 5 seconds with the warning.
>> I also tried the readdir caching optimization that I mentioned before. It brings the time with the warning down to .35 seconds. On real code it's still well below 1% difference. So what do you think? Is this just too risky to add? Updated patch is attached.
> Ugh! Ignore the previous patch. This one actually works correctly.
Ok, the best person to review this is Argyrios, and unfortunately he's out on vacation until August 20th...
More information about the cfe-dev