[cfe-dev] Missing space in lib/buildit of libc++

[Csaba Raduly]

Hi Samuel,

On Wed, Jul 18, 2012 at 11:24 AM, Samuel John  wrote:
> Hi!
>
> Just a little note to libc++'s lib/buildit script:
>
> EXTRA_FLAGS="-std=c++0x -fstrict-aliasing -Wall -Wextra -Wshadow -Wconversion \
>              -Wnewline-eof -Wpadded -Wmissing-prototypes -Wstrict-aliasing=2 \
>              -Wstrict-overflow=4"
>
> And later:
>
> EXTRA_FLAGS+="-isysroot ${SDKROOT}"
>
> I think there is a missing space.

Have you tried it?
GNU make automatically adds a space when appending with +=

See the make documentation (info make):
"""
6.6 Appending More Text to Variables
...
     variable := value
     variable += more

is exactly equivalent to:

     variable := value
     variable := $(variable) more
"""

Note the space before "more".

Hope this helps,
Csaba
-- 
GCS a+ e++ d- C++ ULS$ L+$ !E- W++ P+++$ w++$ tv+ b++ DI D++ 5++
The Tao of math: The numbers you can count are not the real numbers.
Life is complex, with real and imaginary parts.
"Ok, it boots. Which means it must be bug-free and perfect. " -- Linus Torvalds
"People disagree with me. I just ignore them." -- Linus Torvalds