[cfe-dev] Fixits with multibyte chars

[Jordan Rose]

On Jul 16, 2012, at 12:36 , Jonathan Sauer <jonathan.sauer at gmx.de> wrote:

>> I could of course just disable fixits when there are Unicode characters involved, but I'd like to fix this the right way. The trouble is -fdiagnostics-parseable-fixits, which is supposed to be machine-readable output, and in this case is a three-byte UTF-8 character three columns or one column? I think one column is the right way to go, but I wanted to get some other opinions before I start working on a patch.
> 
> I would prefer one column, too. If however this cannot be implemented reliably in all cases,
> I think that a line which is a bit too short would be better than a line which is too long:
> At least it doesn't get wrapped unintentionally.

One more point of interest: the normal column numbers (-fshow-column) also use byte offsets, not character counts. I've added the current behavior to the user manual (and fixed the crash for the fixit line) in r160319.

Jordan